Skip to content

Search: Add the full UI mode for the search result page

Warren Gifford requested to merge vk/add-aggregation-full-mode-ui-mock into main

Created by: vovakulikov

Closes https://github.com/sourcegraph/sourcegraph/issues/40360 Based on https://github.com/sourcegraph/sourcegraph/pull/40138

Background

This PR adds search aggregation full UI mode for the search result page. This PR doesn't imply connecting UI and the real datasets from the backend. It will be addressed later in this issue https://github.com/sourcegraph/sourcegraph/issues/40306

Aggregation UI modes work through URL query param, after you set aggregation mode (or aggregation type) it should be persistent in URL this allows you to share the same aggregation mode and aggreagtion UI that you can see on you screen as you copy URL to share it.

Simple UI mode Standard UI
Screenshot 2022-08-17 at 11 23 58 Screenshot 2022-08-17 at 11 58 51

Todo

  • Restructure aggregation UI models and components for future reuse in the full UI mode
  • Implement the full UI mode screen
  • Connect the sidebar, and the full UI mode states via URL query params

Test plan

  • Make sure that the full mode UI looks visually correct on desktop, tablet, and mobile layouts
  • Make sure that the full UI mode persists state in URL, and after refresh, you still see the full mode UI by default (if you don't close it before refresh)

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading