Skip to content

Search backend: make isGlobal operate on search.RepoOptions

Warren Gifford requested to merge cc/global-refactor into main

Created by: camdencheek

This is a followup from this comment.

Basically, isGlobal should operate on the RepoOptions type rather than the raw query now that the repo options type has all information about what repositories should be searched.

isGlobal is not a method on RepoOptions because our backend packages are too intertwined and this causes circular import issues.

As part of this, I documented that method heavily because I've historically been quite confused about its behavior.

Test plan

Depending on existing tests. Should be semantics-preserving -- it's just moving logic around.

Merge request reports