Skip to content

batches: better responsiveness in y direction

Warren Gifford requested to merge kr/no-squishy-screen into main

Created by: courier-new

Closes https://github.com/sourcegraph/sourcegraph/issues/39902.

I was feeling the need to actually do something with our codebase this week that wasn't docs or hacking around with compute stuff. So, here's a fix to the UI issue reported on screens with limited vertical real estate when there's a lot of errors.

Changes:

  • Caps the max height of the error banner, after which point it's scrollable. Like the feedback panel underneath the SSBC Monaco editor is.
  • Enforces minimum heights on the workspaces list and details container all the time, not just after breakpoints.

Demo with a long error message at various screen sizes with decreasing vertical heights:

https://user-images.githubusercontent.com/8942601/183159753-e0c4034c-1647-4c4c-b03f-0a6e29ad17f5.mov

Test plan

Manual testing at different resolutions with many workspaces and a large error message.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading