Skip to content

search: Show diagnostics for patterns starting/ending with quotes

Warren Gifford requested to merge fkling/quotes-info into main

Created by: fkling

Follow up on #39147

This commit adds diagnostics for patterns that start or end with a quotation mark, including a quick fix action to replace the quote, but only if we are in literal or lucky mode.

If the pattern is completely enclosed in quotes it can also be replaced with the content: filter. The assumption here is that the user used quotes as a way to "escape" the query.

Not sure about the copy text, let me know what you think!

https://user-images.githubusercontent.com/179026/180444735-45dd57bd-e8f8-47d9-b0e7-f416e49a90f2.mp4

Test plan

Enter search query with patterns that beginning or end with a quote. Verify that quick fix action work as expected. Verify that diagnostic is not shown for patterns that contain a quote at a position other than the beginning or end.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading