Skip to content

[SG-38783] Multiple `H1`s on Batch Changes list page

Warren Gifford requested to merge contractors/SG-38783 into main

Created by: gitstart-sourcegraph

Description

All the warnings reported under ARC Toolkit's "Structure and Semantics" tests for Batch Changes page is solved

Problem description

On the batch changes list page (/batch-changes), there are multiple <H1/> elements: the Sourcegraph logo in the navigation bar, and the "Batch Changes" page title, which produces a warning in ARC Toolkit:

image

Expected behavior

  • The "Batch Changes" page title should be an <H2/>, but retain the current style.
  • All other <H2/>s on the page should be downscaled to <H3/>, but retain their current styles.
  • No warnings are reported under ARC Toolkit's "Structure and Semantics" tests.

Refs

Gitstart Ticket Sourcegraph Issue

Test Plan

  • Go to Batch Changes Page
  • Ensure no warnings are reported under ARC Toolkit's "Structure and Semantics" tests
  • Ensure that "Batch Changes" page title should is an h2
  • Ensure that All other h2s on the page should be downscaled to h3

App preview:

Check out the client app preview documentation to learn more.

Merge request reports