Skip to content

[SG-35187] Accessibility: Cannot navigate to link to create repository filters

Warren Gifford requested to merge contractors/SG-35187 into main

Created by: gitstart-sourcegraph

Description

It's currently impossible using VoiceOver to select this link to create a new input field. It currently only reads the leading text, then allows us to skip to the period after the link. Not sure how to navigate properly here.

It is similarly impossible to navigate to the following link once it's clicked outside of the screen reader's journey. Image Image

Expected behavior

Clicking on the link should add additional dynamic forms.

Refs

SourceGraph Issue GitStart Issue

Test plan

  1. We will need to negate repoId into !repoId and also make the prop disabled to false on the child component ReposMatchingPatternList in the file BranchTargetSettings.tsx.
  2. We can then navigate to Configuration policies and expand each of them to do the testing using screen reader. We should be able to tab through and add dynamic form inputs.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports