Skip to content

[SG-35179] Fixing keyboard navigation issues for notebooks

Warren Gifford requested to merge contractors/SG-35179 into main

Created by: gitstart-sourcegraph

Problem description

This PR is all about fixing keyboard navigation issues for notebooks as listed below:

  • Space key can be used to activate a tab in the Notebooks page
  • Notebook block menu items in a Notebook view are always tabbable, even if the block isn't focused or only some items are shown. When focused via tab key, they should become visible. (This likely requires changes to how all Notebook block types set their menu items, since they are currently shown/hidden by removing them from the DOM.
  • Notebook block menu item "Open in new tab" in a Notebook view should be actionable with the space key

Refs

Sourcegraph Issue GitStart Issue

Expected behavior

All issues listed above are fixed

Test plan

Take a look at the issue description. Navigate to URLs mentioned in the description section. All issues should be fixed

App preview:

Check out the client app preview documentation to learn more.

Merge request reports