Skip to content

batches: make SSBC usable on small viewports

Warren Gifford requested to merge kr/ssbc-small-viewport into main

Created by: courier-new

This PR features a number of improvements to the layout responsiveness of screens from the server-side execution flow. Is it pretty on mobile? Absolutely not. But is it functional? More or less!

Rather than attempt to describe the improvements, I took some recordings for you to see for yourself. You can also play with all of these screens in storybook stories. I invite you to try to break them however you can. 😄

Screen Before After
Create
Edit
Execute

One note on that last one, unfortunately I couldn't find an easy fix for maintaining the scroll position when you select a workspace, since we're changing the route. I'm sure there's some way to do it, but it wasn't obvious.

This also fixes https://github.com/sourcegraph/sourcegraph/issues/36470 by restricting the MAX_WIDTH of the workspaces preview panel to a relevant percentage of the total viewport width:

https://user-images.githubusercontent.com/8942601/178426694-aa1b12bd-1eb6-4cf4-92b6-b06bff445266.mov

Test plan

Aggressive manually testing. The main screens should have Chromatic/Percy coverage, which I will also review.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading