Skip to content

[SG-36513] Accessibility: Code monitoring logs screen reader issues

Warren Gifford requested to merge contractors/SG-36513 into main

Created by: gitstart-sourcegraph

Audit type

Screen reader navigation

User journey audit issue

#34194

Problem description

  • Buttons to expand should not have aria-label. Instead, the label should be on the expand/collapse icon.
  • "Monitor details" and "N new results" links should be outside the button and the icon should read "Open in a new tab" SUCESS/SKIPPED/ERROR tags should have aria-label so they are not read as uppercase. The label should read ", monitor state: "
  • Add hidden "Monitor name:" before every name and "Last run:" before every timestamp on the left column

image

Expected behavior

  • Issues resolved as described above.

Additional details

#35151 and #35158 are related issues that should probably be fixed first.

Refs

SourceGraph Issue GitStart Issue

Test Plan

  • Navigate to the Code Monitoring Log page and ensure you're on the Logs tab.
  • Inspect the elements using the developer tool to ensure they ascribe to the above expected behavior.
  • Run the screen reader and ensure that the labels are announced/read as required.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading