Skip to content

[SG-35698] Fix HeroPage icon link missing a label

Warren Gifford requested to merge contractors/SG-35698 into main

Created by: gitstart-sourcegraph

Audit type

ARC Toolkit

User journey audit issue #34112

Description

When using the HeroPage react component, links on the top of the page are represented as an image. If we use the sourcegraph logo icon there, we have 2 problems as a result:

  • The svg is focusable
  • The link does not contain any text or aria-label, so the screen reader cannot interpret where the link goes to or what is the purpose of the link

Refs

Sourcegraph Issue GitStart Issue

Implementation Details

  • The svg itself is not focusable
  • The link contains a label or description, that is not visible by default. If the description/label was not provided, the label should contain the url the link points to

Test plan

To test this PR,

  • Run app on branch and open the issue link
  • Confirm that hero page icons now has a label or hidden
  • Confirm there are no UI diffs

App preview:

Check out the client app preview documentation to learn more.

Merge request reports