Skip to content

[SG-35295] Tree page (post-redesign): Navigation links are reported as buttons

Warren Gifford requested to merge contractors/SG-35295 into main

Created by: gitstart-sourcegraph

Description

image

In the redesign these items should function as links (they navigate) and a navigation list This is not the case:

  • Screen reader reports these as buttons
  • Screen reader loses focus when a button is clicked

Expected behavior

  1. Remove role="button" from these links.
  2. Wrap this links in <ul> and <li>
  3. Wrap the list in a <nav> element - so it is reported as a navigation list to a screen reader
  4. Check if focus is still lost when selecting a button using a keyboard: a. If still not fixed, we can manually move the focus to the new page through JS.

Refs

Sourcegraph Issue Gitstart Ticket

Test Plan

https://www.loom.com/share/95c4e8a8f1e44d58b1a9320451997605

App preview:

Check out the client app preview documentation to learn more.

Merge request reports