Skip to content

internal/trace: reduce direct usages of OpenTracing

Warren Gifford requested to merge 06-29-internal/trace_reduce_direct_usages_of_OpenTracing into main

Created by: bobheadxi

This attempts to consoldiate tracing creation into internal/trace, so that we can more effectively control tracing output, and moves some OpenTracing stuff into an internal package

Used Comby directly for a lot of the rewrites so some things e.g. span.SetError changes are pretty minimal (span.SetError checks for nilness internally but callsites still set it themselves)

There's a few places where I'm not sure how we should migrate so I've just left them as-is and added TODOs

Part of https://github.com/sourcegraph/sourcegraph/issues/27386

Test plan

Tests pass

Merge request reports