Search backend: simplify searcher job
Created by: camdencheek
Two small refactor commits in this PR:
- Remove a temporary construction of
search.RepositoryRevisions
. This was awkward because we're constructing it just to deconstruct it when used. This led to some confusing stuff like uncheckedrepoRevs.Revs()[0]
, which is really confusing for passers-by. Stop nestingg.Go()
. We're spinning up a goroutine only to join it immediately after, which is confusing.
Test plan
Backend integration tests. Semantics-preserving.