Skip to content

fix: do not panic on partial, multi-line highlight

Warren Gifford requested to merge tjdevries/panic_investigation into main

Created by: tjdevries

There were two main problems hidden behind enableFastResultLoading.

The first problem was that if we had occurrences from lines that we skipped (due to only passing certain line ranges), then we didn't discard them in our loop to iterate over the lines.

The second problem was that if we had multi-line occurrences (and we didn't skip certain lines) then we would could access past the last row (this is primarily fixed by part 1, but I added a safeguard to make sure that even if we get malformed scip data that we just return early to avoid a panic).

Test plan

  • Test that repo:^github\.com/abpframework/abp$ core no longer panics with enableFastResultLoading

Merge request reports