Skip to content

[SG-35162] Accessibility: Saved searches screen reader issues

Warren Gifford requested to merge contractors/SG-35162 into main

Created by: gitstart-sourcegraph

Audit type

Screen reader navigation

User journey audit issue

#34658

Refs

Sourcegraph Issue GitStart Issue

Problem description

  • Nothing announced when navigating the Saved Searches page. Expected: the "Saved searches" heading should be focused.
  • Nothing announced/focused when clicking "+ Add saved search" button or clicking the "settings" button on a saved search. Expected: Heading ("Add saved search"/"Managed saved search") should be focused.
  • Nothing announced when submitting the form to add a saved search. Expected: confirmation read and focused is returned to either the "+ Add saved search" button or the newly created saved search in the list.
  • On create/edit page, on the bottom link to code monitoring, the right arrow is read by the screen reader. Expected: the arrow should be aria-hidden.
codemonitoring
  • On list of saved searches, it's confusing what clicking on the saved search name will do. Expcted: the saved search name link should have a visually-hidden component that says "Click to run saved search" or similar.
  • On list of saved searches, after deleting a saved search, no confirmation is read. Expected: Announcement should be read confirming the deletion.

Expected behavior

  • Issues are resolved as described above.

Test Plan

  • Make a search on the home page.
  • Click on the save search button and before saving it activate your screen reader. On saving you should hear it being announced Save Search successful and then navigated to the list of saved search items.
  • On the saved search list page, the + Add Save Search button should be focused.
  • When you navigate on the list item using the screen reader, it should announce Click to run saved search.
  • When you delete a saved search list item, it should announce Deleted the saved search name_of_saved_search after clicking ok button of the browser alert.
  • The → should be arai-hidden and not read by the screen reader on the bottom link to code monitoring.

Loom Video

https://www.loom.com/share/50ca9c1b756248a691ae9b5f8ea998e8

App preview:

Check out the client app preview documentation to learn more.

Merge request reports