Skip to content

batches: Display reattach changeset

Warren Gifford requested to merge rc/reattach-changeset into main

Created by: Piszmog

Closes #36359 (closed)

When an existing changeset is completely detached (not associated with any batch changes) and reattached to a change change, it would show up in the UI without an associated action/operation and the stats (in the banner) were un changed.

This PR does the following,

  • Adds a new ChangesetSpecOperation called REATTACH
  • Added a Reattach stat to the banner and a reattach operation is an addition (added) stat
  • Updated DeterminePlan to take a "current changeset" so there is something to compare against to know if a changeset is being reattached
    • Rewire modifies changesets into a wanted state, so needed a way to know what changed
  • Bonus: Fixed some variable and package naming collisions
  • Bonus: Updated PreviewActions.tsx to use wildcard Tooltip since data-tooltip is deprecated

Test plan

Go Unit tests, existing storybook, typescript unit tests, and manual testing (see screenshot below).

Screen Shot 2022-06-22 at 10 43 42

Merge request reports

Loading