Skip to content

JetBrains: change metadata panel UI to match the designs

Warren Gifford requested to merge dv/jetbrains-design-metadata-panel-ui into main

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/37280

The change is not only in the design but also in functionality: the component wasn't accessible with the mouse; now it is.

Also:

  • Extracted the metadata panel to its own class to encapsulate that functionality. The interfaces got a lot cleaner as a result.
  • Set a minimum size for the window and the web view because at lower widths, the search box started breaking and it looked bad. The minimum height for the web view also makes it less likely that the Monaco Editor suggestion box bug comes up for users.
  • Set cursor: default on status bar to get rid of this giveaway that we're in a web view.
  • Tiny change: Suppressed a false warning with also including a comment on why it was false.

Test plan

  • Check out this 1-min Loom
  • Take a glance at the code. Might even be easier to go commit by commit; I've tried to make the commit messages pretty helpful.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading