Skip to content

Fixing LastSyncedIcon and Tooltip Positioning on Search Result Page

Warren Gifford requested to merge LM/tooltipPositioningFix into main

Created by: lmelende20

I changed the positioning of the LastSyncedIcon by eliminating the absolute positioning. The absolute positioning was what was causing the tooltip to appear in the top left of the div. So, I positioned the icon where it was being called in RepoSearchResults.tsx and FileMatchChildren.tsx. There are two other files that call and utilize LastSyncedIcon so, those files may need to be modified as well.

Test plan

Changes were made to the LastSyncedIcon on the search result page

  • Enter a search query at the Sourcegraph website
  • This redirects you to the search result page
  • The LastSyncedIcon should be on the top right of each search result container
  • Hover over the icon to view the tooltip
  • Test is successful if the icon is actually in the top right of each search result container and the tooltip appears directly next to the icon

App preview:

Check out the client app preview documentation to learn more.

Merge request reports