Skip to content

batches: add snapshot coverage for execution screen with selected workspace

Warren Gifford requested to merge kr/chromatic-coverage-for-selected-workspace into main

Created by: courier-new

Would have helped detect a regression from https://github.com/sourcegraph/sourcegraph/pull/37089.

  • Adds a Storybook story variant for ExecuteBatchSpecPage which has a workspace selected. These stories have Chromatic snapshots turned on.
  • Improves mock step data for an actively-executing workspace
  • Hides the loading spinner in Percy/Chromatic. We hide other animated parts of the UI like videos and auto-opening pop-overs that can otherwise cause flakes, and now that the loading spinner will be visible on snapshots for ExecuteBatchSpecPage, I want to pre-empt flakes by hiding it there, too. I originally just hid it on our page, but I think it might do us favors in the future to just hide it across the board. It looks like the loading spinner maybe doesn't cause flakes, so I won't change it for now. 🙂

Test plan

The point of this PR is literally to add another test. 😄

App preview:

Check out the client app preview documentation to learn more.

Merge request reports