Skip to content

[SG-34735] Search homepage screen reader issues

Warren Gifford requested to merge contractors/SG-34735 into main

Created by: gitstart-sourcegraph

Implementation Detail

  • Clicking "Show more" buttons in panels doesn't announce anything and keeps focus on the "show more" button (should focus on the newly added item instead)

  • Repositories panel, recent files panel, and saved searches panel contents should be tables with headings, not a list (and make sure they don't read "bullet" before each item anymore)

  • "My searches"/"All searches" should be exposed as tabs, not buttons

Description

  • Replaced the lists in the Repositories panel, recent files panel, and saved searches panel contents with a table view
  • Modified recent files panel so when the view more button is clicked focus is shifted to the recent file items
  • Added Tab roles to Saved search filter buttons.

Refs

SourceGraph Issue Gitstart Ticket

Test Plan

  • On Search homepage panels, using screen reader, verify the content of Recent files panel, Saved search panel and Repositories panel are recognized/read in table rows and columns
  • On Search homepage, using screen reader, verify the "My searches"/"All Searches" Buttons are read as tabs.
  • Click "Show more" button in any of the search homepage panels and press shift + tab when the see more button loses focus to see current focus.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports