Skip to content

batches: use custom style for instances of `Select`

Warren Gifford requested to merge kr/custom-select-style into main

Created by: courier-new

Potentially fixes the "doesn't match Wildcard" part of https://github.com/sourcegraph/sourcegraph/issues/37116.

I don't claim to know why we have a "native" version of Select, nor do I know why it's the default, but the "custom" variant looks to be what we want to use to match Wildcard. Screenshots from Safari, like in @danielmarquespt's original report:

Screen Shot 2022-06-13 at 10 10 43 PM

Screen Shot 2022-06-13 at 10 10 51 PM

Screen Shot 2022-06-13 at 10 11 00 PM

Test plan

Manually tested all three instances of Select in Chrome, Brave, and Safari. I think these instances are also covered by Storybook and should probably trigger a diff on Chromatic.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading