Skip to content

[SG-36339] Wildcard <Icon /> accessibility, Enforce aria-label / aria-hidden

Warren Gifford requested to merge contractors/SG-36339 into main

Created by: gitstart-sourcegraph

Implementation details

After Completion of #407 (closed) Enforce Icon so we have to pass either aria-label OR aria-hidden to the component, we can change this code to enforce it by removing the ? and everything should work

NOTE: This might find a few places where people have added Icon usage as we have migrated - so we might need to add a few more labels/hidden. This could be resolved by taking Note of linter errors that might come up after implementation.

Refs

Sourcegraph Issue GitStart Issue

Time estimate

  • Pull requests with frontend lines changed should take 2 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.
  • Split the work into multiple pull requests if the total diff is bigger than 450 lines of code.

Test Plan

  • Ensure all have either aria-label OR aria-hidden and there is no linter failing.
  • There shouldn't be any UI Change.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports