Skip to content

ssbc: Don't keep execution results, recreate from steps

Warren Gifford requested to merge es/no-cache-exec-results into main

Created by: eseliger

This drops execution cache results from SSBC entirely (not step results, just execution) and only uses step cache results instead. The cache LRU swaps them out eventually so we don't need a costly migration. This is accomplished, by porting the logic to convert a step cache result into changeset specs into the backend. No executor run is required for the scenario where we have all step entries but no execution result anymore due to cache eviction, and we reduce data duplication in the database. Most notably, check that I adjusted the test to not include a cache entry log line anymore, but all the changeset specs are still generated, just as before.

As a side-effect, this closes https://github.com/sourcegraph/sourcegraph/issues/36540.

Test plan

Removed code and tests still pass! Also, I tested manually to double-check.

Merge request reports

Loading