[SG-34737] Accessibility: Search results screen reader issues
Created by: gitstart-sourcegraph
Audit type
Screen reader navigation
Description
This PR is all about some of the screen reader issues with respect to search results
User journey audit issue
https://github.com/sourcegraph/sourcegraph/issues/34190
Ref
Sourcegraph Issue Gitstart Ticket
Test Plan
- Ensure integration test have accessibility audit and that those tests pass.
- Use screen readers (check here how) to go through the changes and it should read as expected.
Checklist
-
User not notified when results come in or search completes (probably should aria-live on progress element, adding a hidden label to state that the search is in progress or completed) 
-
(i) icon next to result count not labeled and doesn't read the tooltip contents
-
When search query is not diff/commit, disabled state "Monitor" button not announced by screen reader
-
Caret dividing repo from filename should be aria-hidden
-
Hide/show all matches button read twice by screen reader
-
On type:symbol search results, the type icon next to each symbol is not read by screen reader (should have label based on symbol type)
-
On diff/commit search results, git hash and time read together (should have some sort of separation, maybe a hidden comma)
-
Colon between author and commit description should be aria-hidden
-
Sidebar section collapse button title not read by screen reader (modify aria-label to also have the section title)
-
Clicking on a link in the sidebar that edits the search query doesn't notify the user that they are now editing the query (should announce this to the user) -
Links in the sidebar and no results page have an icon that indicated they will open in a new tab, but this icon is not read by the screen reader
-
Video thumbnails on the no results page should be aria-hidden or should be changed to presentation role with empty alt
App preview:
Check out the client app preview documentation to learn more.