Skip to content

[SG-34723] Accessibility: Search results misc keyboard bugs

Warren Gifford requested to merge contractors/SG-34723 into main

Created by: gitstart-sourcegraph

Audit type

Keyboard navigation

User journey audit issue #34190

Refs

Gitstart ticket Sourcegraph issue

Problem description

The following problems exist for keyboard navigation on the result page:

On the header:

header

  • Cannot focus (i) icon next to results count with keyboard to see number of repos
  • "Create context", "Create insight", "Monitor" and "Save Search" buttons cannot be activated with spacebar
  • Clicking on "save search" and then clicking "save query" on the dialog navigates to the save search page, the description box should be focused by default

On search results items:

search results items

  • Last sync time icon cannot be focused with keyboard to see the last synced time

On the no results page

results page

  • "Run search" link in examples cannot be focused with the keyboard

Odd focus ring around no results page examples alt

  • Should not be able to focus toggles on no results page examples

Test Plan

Ensure integration test have accessibility audit and that those tests pass. Use screen readers (check here how) to go through the changes and it should read as expected.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports