Skip to content

[SG-34738] Accessibility: Search results ARC checklist issues

Warren Gifford requested to merge contractors/SG-34738 into main

Created by: gitstart-sourcegraph

Audit type

Screen reader navigation

User journey audit issue

#34190

Ref

Sourcegraph Issue GitStart Issue

Problem description

  • On empty search results page, toggles (case sensitivity, etc) in "The search bar" section and other example searches should be aria-hidden search

  • Search result type icon is not labelled (should be labelled based on type of result) search-result1 search-result2

  • Code host icon should have role="img" and label on it directly instead of nested inside a span codehosticon

  • Star icon is not labelled (should be labelled "n stars", where n is the number of stars; the number next to it should be aria-hidden) starticon

  • Last sync icon is not labelled (should have label same as the tooltip content lastsyncicon

Expected behavior

Should be fixed as described above

Test Plan

  • Ensure integration test have accessibility audit and that those tests pass.
  • Use screen readers (check here how) to go through the changes and it should read as expected.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports