Skip to content

[SG-35169] Saved Searches ARC toolkit issues

Warren Gifford requested to merge contractors/35169 into main

Created by: gitstart-sourcegraph

Description

  • Added aria-hidden to '+ Add saved search" icon, saved search icon, settings icon, and delete icon
  • Changed Header on user/org profile page to h2.
  • Changed Header on saved searches pages ("Saved searches" on list page and "Add saved search"/"Manage saved search" on create/edit page) to h3.

Refs

SourceGraph Issue Gitstart Ticket

Test Plan

  • On the Saved searched panel, using screen reader, verify the SVG icons for "+ Add saved search" is not read.
  • Using screen reader, verify the SVG icons in saved search list (saved search icon, settings icon, delete icon) are not visible to the screen reader.
  • Using screen reader, verify the header on saved searches pages ("Saved searches" on list page and "Add saved search"/"Manage saved search" on create/edit page) are read as a level 3 heading.
  • Using screen reader, verify the Header on user/org profile page (user/org name) is read as a second level header.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports