Skip to content

dependencies: Do not hard fail when a commit cannot be resolved

Warren Gifford requested to merge m/lockfiles-hard-fail into main

Created by: mpimenov

A typical case is an organization that has empty repositories (say, useful because of another code host feature, such as an issue tracker).

We would resolve the commits from valid repos but fail to resolve the commits from empty repos, and since our usage of the resolver did not ignore the errors, we would fail.

Whether the ignoreErrors flag in GetCommits should exist at all, now that we have removed its only client, is a matter of a separate PR.

Updates #34977

Test plan: backend-integration pipeline on Buildkite at https://buildkite.com/sourcegraph/sourcegraph/builds/148471

Merge request reports