Skip to content

fix: extension update and publish buttons accessibility issue

Warren Gifford requested to merge bee/fix-aduit-publish into main

Created by: abeatrix

Closes https://github.com/sourcegraph/sourcegraph/issues/34851 + https://github.com/sourcegraph/sourcegraph/issues/34839, these are bugs identified while performing an accessibility audit https://github.com/sourcegraph/sourcegraph/issues/34050

Summary

When trying to Update the name of the extension & Publish the extension, I noticed:

The Update Extension button does not trigger anything after the form has been submitted. This caused confusion when using the Voice Over feature to navigate this task because I was not able to confirm whether I have clicked on the button correctly and if the extension has been updated after the button click. To fix this, I updated the “Update Extension” button (the one used by the Publish button) to display if the extension has been updated successfully, and the screen reader will then read the message via the aria-live option.

Before

image

After

image

For the Publish button, since the page does not re-render after the button is clicked, we should add the aria-live option to read the status message after the button is clicked to let the users know if the extension is published successfully or not.

Test plan

Tested using screen reader

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading