Skip to content

batches: persist last-selected filters to temporary settings

Warren Gifford requested to merge kr/temporary-settings-bc-list-filters into main

Created by: courier-new

Closes https://github.com/sourcegraph/sourcegraph/issues/32754.

Uses Temporary Settings to persist the last-selected set of state filters chosen in the MultiSelect for the batch changes list:

https://user-images.githubusercontent.com/8942601/158947087-d660c283-0dd3-4d1c-a008-bfe5f4f54f99.mov

In doing so, I packaged up all of the logic related to these filters into its own hook to reduce complexity inline with the BC list page component.

The persistent filters work for existing customers (without server-side execution enabled), as well. Of course, with only OPEN and CLOSED to choose from, the benefits are fewer for them.

Test plan

Verified manually both with and without server-side execution enabled that filters a) default to ALL, b) retain expected filtering behavior, and c) persist last-selected options between visits.

Merge request reports