Skip to content

post sign-up: Various fixes

Warren Gifford requested to merge ps/post-sign-up-improvements into main

Created by: philipp-spiess

Fixes https://github.com/sourcegraph/sourcegraph/issues/31834

This PR has a collection of fixes as according to this Figma and this Slack thread.

  • Fixes the "Not right now" button in dark mode
  • Fix margins of the teams beta form
  • Pre-fills username in the teams beta form
  • Changes the text on the invite collaborators page
  • Various responsive mode improvements

Open questions

  • @rrhyne please take a not at the "Invite Collaborators Responsive Changes" part of the test plan. These are probably the biggest changes that I've made that divert the design quite a bit but I felt like the current version of having the two sides stacked even on very small screens/mobile was really awkward.

Test plan

UI/UX changes

Light mode Dark mode
Skip this step button fixes skip-this-step-light-mode skip-this-step-dark-mode
Responsive Code Hosts responsive-code-hosts n/a
Teams Beta teams-beta-responsive-light-mode teams-beta-responsive-dark-mode

Invite Collaborators Responsive Changes

https://user-images.githubusercontent.com/458591/155718704-a64d82f1-ebdc-47fe-afab-7e7398b42155.mov

Form auto-filling

Since this implementation takes use of custom DOM events I wanted to verify this across more browsers just to be sure. The field is not hidden yet so the test is visible but once we hide it the logic stays the same.

Chrome Firefox Safari
form-filling-chrome form-filling-firefox form-filling-safari

Merge request reports