Skip to content

Point thread-loader at Sourcegraph fork

Warren Gifford requested to merge update-thread-loader into master

Created by: kevinburke

The thread-loader package starts several subprocesses. When you send a SIGINT to thread-loader, the subprocesses terminate, but the parent process hangs while waiting for them to send data. We were not listening for the 'end' event in the parent process which meant that the webpack processes would just hang forever.

Fix this by listening for an 'end' event, which means we can signal to Webpack that the job terminated with an error, instead of not terminating. This means that SIGINT will actually shut down the process instead of leaving it hanging forever.

Updates webpack-contrib/thread-loader#33. Updates webpack-contrib/thread-loader#34. Updates webpack-contrib/thread-loader#35. Updates webpack-contrib/thread-loader#36.

This PR does not need to update the CHANGELOG because it's not really user facing.

Merge request reports