honeycomb: slice-wrap values for multiple insert of same key (!29652) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge nsc/honeycomb-multi-data into main Jan 12, 2022

Created by: Strum355

Currently, if AddField n co are called multiple times for the same key, only the last value remains. This can happen using the observation package with the traceLogger.

With this PR, if a key is added multiple times, it will be wrapped in a slice after the second insert and that slice appended to thereafter.

We apply a custom JSON marshalling scheme for (subjectively) optimal representation in Honeycomb. Image 1 shows what it would look like normally, Image 2 shows the custom marshalling:

honeycomb: slice-wrap values for multiple insert of same key

Merge request reports