Skip to content

[CLOUD-78] [CLOUD-80] authz: skip user-centric perms syncing from code host on dotcom

Warren Gifford requested to merge jc/CLOUD-80-CLOUD-78-skip-perms-fetch into main

Created by: unknwon

I have been monitoring our perms syncing graphs after we shipped #26081, what I found surprising are two things:

  1. The queued item in our perms syncing queue never reached to zero, from the graph below we can see that is because external services are synced faster than the perms syncer can handle (i.e. keep adding more items to the queue than the perms syncer is able to process within same period of time). Part of it is due to our perms syncer is single-thread, which will be addressed separately.
  2. Some 95th user-centric perms syncing took > 1 minute, which is a really long time given we solely rely on listing entries from external_service_repos table for user-centric syncing on dotcom. This PR makes sure we send no API request to the code host because we don't use the results anyway on dotcom (see why in code comments).
CleanShot 2021-10-22 at 18 22 03@2x

Impact

Getting user-centric perms sync duration to <1s is essential to unblock the final PR of CLOUD-80 which got reverted one time due to we can't process perms syncing items fast enough, and users would have to wait for very long to make private repositories show up in their search results. As well as unblock the perms work in CLOUD-80 for the same reason.


Jira: CLOUD-78, CLOUD-80

Merge request reports

Loading