Skip to content

dev/sg: move RFC functions into package internal/rfc

Warren Gifford requested to merge sg/rfc-package into main

Created by: bobheadxi

I'm hoping to embed Buildkite query functionality using e.g. https://github.com/buildkite/go-buildkite into sg (for https://github.com/sourcegraph/sourcegraph/issues/25562). It will likely have its own auth token to store and client to make. The RFC command features a lot of generically named helpers that was making this awkward, so I extracted them out of the root package to avoid polluting the namespace even further. I also moved a few things I anticipate being shared int urlutil open and root

Main code changes:

  • Google token path that gets stuff from ~/.sourcegraph is now joined from the new GetSGHomePath(), which can be used as a home for other bits of sg data
  • RFC functions accept *output.Output for writing things

Merge request reports