Skip to content

move Location, Range, and MatchedString into `internal/search/result`

Warren Gifford requested to merge cc/merge-highlight-types into main

Created by: camdencheek

This moves the Location, Range, and MatchedString types from the gitserver protocol package into our search package so they can be reused outside of gitserver. The design of these types are based off the similarly-named types in the compute package.

Once the new commit/diff search is default and the old search path is removed, I'd like to start pushing these types up into our result types so that we can more correctly represent multi-line matches throughout our backends. For now, I'm just moving them into a sharable package.

Stacked on #25568 Progresses to #25175 (closed) (doesn't actually completely fix it, but I think this is as far as I want to go this sprint)

Merge request reports