Skip to content

feedback from streaming search PR

Warren Gifford requested to merge backend-dry-run/cc/streaming-searcher-clean into main

Created by: camdencheek

Followup to #23754. Github rejected my push yesterday with the commit implementing @rvantonder's feedback, and I didn't notice it before I merged this morning.

There should be no behavior changes with this commit, just readability/style.

Changes:

  • Move stream search into its own function
  • Rename cb/callback to onMatches
  • Move toMatches into its own function (so it can be re-used elsewhere)

Merge request reports