Skip to content

search: remove parse tree dependency to resolve repos

Warren Gifford requested to merge backend-dry-run/rvt/lift-repo-opts into main

Created by: rvantonder

Stacked on https://github.com/sourcegraph/sourcegraph/pull/22823.

Semantics preserving modulo a small change to trace output. The PR changes the signature of resolveRepositories:

  • resolveRepositories(ctx, <parse tree>, <random options>) to resolveRepositories(ctx, <processed-repo-options>)

The effect is that resolveRepositories no longer depends on <parse tree> and can simply receive and use the <processed-repo-options> it cares about. This is achieved by doing said processing before calling resolveRepositories. More inline comments to motivate why.

Merge request reports