Skip to content

extensibility: fix browser extension for private code on Cloud

Warren Gifford requested to merge tjk/bext-private-cloud into main

Created by: tjkandala

Closes #22444 (closed).

"Private code" hover alert only appears when we know that the repo isn't on Cloud, native tooltips aren't disabled. Screenshot from 2021-07-08 12-36-44

Browser extension works with private code that has been added to Cloud. Screenshot from 2021-07-08 12-36-15

Notes:

  • Potential risk: we can longer block all GraphQL requests from extensions to Cloud on the basis that the currently viewed repository is private.
  • Testing: we will start with manual testing, then add integration tests for this use case as part of our DX project around automating browser extension testing.

TODO:

  • Don't show popup private repo alert when the repo has been added to Cloud
  • Update popup private repo alert copy (no action for now, we've added a link to "how to add public repos to Cloud" on the hover alert that hints at private code coming to Cloud)

Merge request reports