Skip to content

Check props for deep equality in ActionsNavItems

Warren Gifford requested to merge tj/search-actions-jitter into main

Created by: tjkandala

Fix #19230 (closed), #19243 (closed)

Regression from #18898, which refactored <ActionsNavItems> to a function component. It now requires extraContext to be memoized, or else it will refetch actions on every render.

Fix: memoize extraContext in <SearchResultsInfoBar>

After GIF

Update: prevent this issue from happening in the future by checking for deep equality of scope and extraContext in <ActionsNavItems>. It would be hard to memoize Panel scope, but the object is so small and deep equality check is so fast that it shouldn't matter that it runs on each keystroke.

Panel GIF

Merge request reports