Skip to content

Add feedback prompt to navigation

Warren Gifford requested to merge feedback-trigger into main

Created by: 5h1rU

Overview

This PR adds a feedback prompt to our navigation bar. This is a simple textarea and emoji selector that users can utilise to quickly provide feedback from anywhere within our webapp.

Data flow:

  1. User writes feedback and chooses a rating, clicks 'Send'
  2. We submit the feedback and current URL through a new GraphQL mutation submitHappinessFeedback
  3. Through GraphQL, we attach the SiteId the user is submitting from. If we are on Sourcegraph Cloud, then we also attach the email of the user
  4. Data is sent to HubSpot and processed there

Video

https://user-images.githubusercontent.com/9516420/107954597-8c065400-6f94-11eb-8933-b9d45d831de7.mov

Design

There is some relevant design discussion about this component here. Some small UX differences compared to our other nav items are not applied in this PR. Reasoning: We're wary of significantly changing our nav items technically just to achieve this single variation. We think, as a larger scope of work, we should consider reviewing all of our nav items in order to improve both UX consistency and technical implementation. The current implementation of our nav items does not support these UX variations easily, and we're worried that we will have similar problems in the future.

Progress

  • Documentation text/screenshots updated (if relevant)
  • Approved by a frontend engineer (if touching frontend code)
  • Approved by a backend engineer (if touching backend code)
  • Approved by a designer (if it touches the UI)

Closes #17644 (closed) Closes #17645 (closed)

Merge request reports