Skip to content

monitoring: allow page load latency to be NaN

Warren Gifford requested to merge distribution/page-load-latency into main

Created by: bobheadxi

It seems histogram_quantile can return NaN if all buckets are 0, for example on low-traffic instances.

With this change:

Screen Shot 2020-10-05 at 5 54 13 PM

Orange bar is the threshold, green is the metrics correctly not going above that threshold.

Just going with this solution because I was unable to find the "right way" to get around this. Closes https://github.com/sourcegraph/sourcegraph/issues/14401 (which has more details)

Merge request reports