Skip to content

search: add more traces

Warren Gifford requested to merge sh/better-traces into main

Created by: stefanhengl

Currently, we only trace file/path searches. This PR adds traces for all results types, at least on the highest level. We also increase the granularity of traces for getting user settings.

Learnings from this change:

  • we access user settings twice, before and after search (fix costs, marked in orange)
  • repository search (default result-type, marked in red) might be a bottleneck for larger index sizes because repo resolution is on its critical path. Streaming will probably mask this problem though.

There is still a gap after the end of doResults. I will look at this next.

image

Merge request reports