Skip to content

campaigns: Reload after toggling the feature flag

Warren Gifford requested to merge aharvey/reload-on-campaign-enabled into master

Created by: LawnGnome

This PR will reload the user's frontend if they've just toggled the Campaigns feature flag. Simple, right?

Interesting bits:

  1. We can now define whether the frontend should be reloaded on a per configuration setting basis.
  2. Configuration change results are now reported on a per-change basis, rather than relying on global site state.
  3. As the previous updateSiteConfiguration mutation couldn't be extended to report more than a Boolean!, a new overwriteSiteConfiguration mutation has been added with similar semantics, but a more extensible return value. We should remove updateSiteConfiguration in a couple of versions, per the GraphQL making breaking changes documentation. (What's our process there? File an issue?)

Fixes #10715 (closed).

Merge request reports