Skip to content

Duplicate requests to phabricator API from sourcegraph extensions

Created by: aisbaa

  • Sourcegraph version: 3.12
  • Platform information: phabricator custom integration and chrome extension v20.2.5.1810

Steps to reproduce:

Looks like it for every file changed in diff - javascsript part of sourcegraph in phabricator does:

  1. Open diff in phabricator with one file changed.
  2. Inspect requests made to phabricator API.
  3. Open diff with more than one files changed.
  4. Inspect requests made to phabricator API.

For the following cases I've used only sourcegraph extension integrated into phabricator. Browser extension was turned off.

Diff with 1 file changed:

Screenshot 2020-03-06 at 13 22 50
  • 1 or more diffusion.repository.search
  • 1 or more differential.getrawdiff
  • 2 differential.querydiffs

This one seems fine only one duplicate request.

Differential.querydiffs calls have the same arguments passed and the same response.

Diff with 10 files changed:

Screenshot 2020-03-06 at 13 16 02
  • 10 times diffusion.repository.search
  • 10 times differential.getrawdiff
  • 20 times differential.querydiffs
  • 10 times differential.query

For all requests above 9 were duplicates with exception to differential.querydiffs, where 19 requests were duplicates.

Expected behavior:

Expect not to see duplicate API requests

Actual behavior:

See duplicate API requests