Skip to content

Interactive mode filters have trouble with double quotes

Created by: rvantonder

So, there's some trouble with the below behaviors. I expect that instead of the below, either of the following happens:

  • My input gets quoted automatically (so file:" turns intofile:"\"") OR
  • My input is invalid (if I put a " I get an error)

I would prefer the former, but either way what ends up happening with these inputs currently is weird and unexpected. Don't get me wrong, I like interactive search (especially if we do the quoting automatically in the raw input), just think we should be careful about validating the inputs. The following may seem contrived, but if we provide content: it is reasonable that a user might want to search for ", in which case we must ensure that quote the pattern for the user, or error on " entry and warn them that they need to quote the pattern themselves.

quotes-1

In the above case, putting a single double quote for repo, and then a single double quote for file merges the pill and assigns the value " file:" to the repo filter.

quotes-2

In the above case, ">"" doesn't create a UI filter image at all, and ends up searching for ". What happens is that this turns into the query file:">" "