Skip to content

File tree breaks when file has single quote in its name

Created by: felixfbecker

We pass the file path into a CSS selector without escaping quotes.

https://sourcegraph.com/github.com/psconfeu/2019/-/tree/sessions/Chrissy%20LeMaire

Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '[data-tree-path='sessions/Chrissy LeMaire/dbatools - 15 can't miss commands.pptx']' is not a valid selector.
    at z (https://sourcegraph.com/.assets/scripts/95-bb9138570faabc354226.chunk.js:1:822)
    at ne.selectNode (https://sourcegraph.com/.assets/scripts/95-bb9138570faabc354226.chunk.js:1:16128)
    at Object.setActiveNode (https://sourcegraph.com/.assets/scripts/95-bb9138570faabc354226.chunk.js:1:16455)
    at Object.W.linkRowClick [as onClick] (https://sourcegraph.com/.assets/scripts/95-bb9138570faabc354226.chunk.js:1:6929)
    at t.n.handleClick (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:27:122820)
    at onClick (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:27:123459)
    at Object.<anonymous> (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:881)
    at c (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:919)
    at https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:1557
    at C (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:1646)
    at S (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:2082)
    at x (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:1894)
    at N (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:2981)
    at _n (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:30345)
    at Tu (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:98404)
    at Me (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:10256)
    at Sn (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:30825)
    at https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:98681
    at Object.t.unstable_runWithPriority (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:89:3196)
    at ku (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:98606)
    at On (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:80:30568)
    at HTMLDocument.a (https://sourcegraph.com/.assets/scripts/app.bundle.js?4e49a3870ff49c84913ee4291d01f8b9:111:11586)
helpers.ts:109

cc @attfarhan