repo-updater: Take `ExternalRepo` into account in `RepoLookup`
Created by: mrnugget
In https://github.com/sourcegraph/sourcegraph/pull/3967#discussion_r283293070 @tsenart noticed that we do not take the ExternalRepo
field of protocol.RepoLookupArgs
into account:
The protocol.RepoLookupArgs
matches the external_*
columns we have in the repo
table:
There are multiple places in the codebase that make use of this field:
We can either:
- Only use
ExternalRepo.ServiceType
in theKinds
field ofrepos.StoreListReposArgs
- Extend the store with a
GetRepo
method that takes in aGetRepoArgs
that hasExternalId
,ExternalServiceType
,ExternalServiceID
fields