Remove style duplication caused by the `forkedBranded.scss` file
Created by: valerybugakov
Problem statement
Duplicated branded.scss
in the VSCode package makes it hard to keep the theme consistent between all Sourcegraph clients.
Success criteria
The forkedBranded.scss
file is removed in favor of the branded.scss
import.
Implementation details
- Rename
client/branded/src/global-styles/index.scss
toclient/branded/src/global-styles/base.scss
- Move
@import './highlight';
frombase.scss
toclient/branded/src/global-styles/index.scss
-
client/vscode/src/webview/index.scss
should importclient/branded/src/global-styles/base.scss
instead offorkedBranded.scss
- All style changes specific to the VSCode theme should be made in the
client/vscode/src/webview/index.scss
Time estimate
- The task should take 8 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.