Lucky search improvements for MVP
Created by: rvantonder
It's now possible to interpret a query in a lot of smart-ish ways. There are two usability issues that stop this from being a first rate feature:
-
Currently we don't track whether a generated search job returns results. Right now though, we return an alert even if the query just ran (and it may return no results). If we can just track this info, we can use it to know whether to display proposed queries that ran and returned results. I have a sense that we can add the bookkeeping to the stream func without too much hassle, but maybe I'm over simplifying.
-
It looks generated jobs continue to run even past the 500 result limit. This shouldn't be happening and the code exists to return early, but there is probably some bug.
Here is a query that illustrates both of the above issues (the first couple of queries return no results, we shouldn't show them--the last 2 or three return results beyond 500 results, for some reason). Note this was on a local machine and depends on your repos:
A MVP launch will depend on thinking a bit more carefully about deduplication strategies, but that's not really part of this issue.